0000021: Data corruption on raid due to bad allocation of raid_id (Crosslinked Character Signups)

WoW Raid Manager Defect Tracking System

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000021

[WoW Raid Manager (WRM)] Raid View/Signup Issues

major

sometimes

2008-07-09 00:18

2008-07-09 00:19

Reporter

douglasw

View Status

public

Assigned To

douglasw

Priority

immediate

Resolution

fixed

Status

closed

Product Version

3.2.0

Summary

0000021: Data corruption on raid due to bad allocation of raid_id (Crosslinked Character Signups)

Description

When a character goes to sign up for a raid, the signup gets crosslinked with the last character to have already signed up for the raid. This is due to the re-declaration of the "raid_id" variable in the signup code.

Initially the raid_id varaiable gets set to the signing up character's char ID. If the user has "Disable Signup to Drafted Status" unchecked however the character ID is RE-ASSIGNED to the char ID of whatever is currently in the signup table (the last CharID that is signed up) due to the duplicate use of raid_id as a variable name.

elseif($mode == 'signup')
{
// setup post vars
$char_id = scrub_input($_POST['character']); <=== ORIGINAL DECLARATION

(snip)

if($phpraid_config['auto_queue'] == '0')
{
// now check class limits
// setup the count array
$count = array('dr'=>'0','hu'=>'0','ma'=>'0','pa'=>'0','pr'=>'0','ro'=>'0','sh'=>'0','wk'=>'0','wa'=>'0');
$sql = sprintf("SELECT * FROM " . $phpraid_config['db_prefix'] . "signups WHERE raid_id=%s AND queue='0' AND cancel='0'",quote_smart($raid_id));
$result_char = $db_raid->sql_query($sql) or print_error($sql, mysql_error(), 1);
while($char = $db_raid->sql_fetchrow($result_char))
{
$char_id = scrub_input($char['char_id']); <==== RECECLARATION
$sql = sprintf("SELECT * FROM " . $phpraid_config['db_prefix'] . "chars WHERE char_id=%s", quote_smart($char_id));
$result_count = $db_raid->sql_query($sql) or print_error($sql, mysql_error(), 1);
$tmp = $db_raid->sql_fetchrow($result_count);

( SNIP )

}

Fixed in Patch 4 of WRM 3.2.0 - http://www.wowraidmanager.net/e107_plugins/forum/forum_viewtopic.php?235 [^]

Additional Information

Notes
(0000018) douglasw (administrator) 2008-07-09 00:19	Resolved in patch 4 to wrm 3.2.0 and released in full in 3.2.1.

Issue History
Date Modified	Username	Field	Change
2008-07-09 00:18	douglasw	New Issue
2008-07-09 00:18	douglasw	Status	new => assigned
2008-07-09 00:18	douglasw	Assigned To	=> douglasw
2008-07-09 00:19	douglasw	Status	assigned => closed
2008-07-09 00:19	douglasw	Note Added: 0000018
2008-07-09 00:19	douglasw	Resolution	open => fixed
2008-07-09 00:19	douglasw	Fixed in Version	=> 3.2.1

Relationships